Fix Book Binder #3299
Closed
Fix Book Binder #3299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalshyDev
added
the
hacktoberfest-accepted
WalshyDev
previously approved these changes
Nov 6, 2021
Closed
Sfiguz7
previously approved these changes
Nov 7, 2021
svr333
removed
the
hacktoberfest-accepted
|
Could you please cleanup the changelog? |
|
just remove the changelog changes? |
|
Sorry for the commit mess |
|
Would someone want to test these changes again to be sure everything works as intended that way we don't have the mess that was the last enchantment related PR. |
7 tasks
J3fftw1
approved these changes
Aug 3, 2023
|
Closing this in favour of #3925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there is an issue with the Book Binder.
If you combine 2 books of the same level and the resulting level will go above the set limit (either vanilla or custom) the books will combine into one and keep their current level.
This fix makes it so that if a
Fortune IIIgets combined with anotherFortune III, it will not be combined into anotherFortune III(granted there is no custom limit)This has no effect for books with multiple enchantments as both books have the same level
Proposed changes
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values